Fix failing logging.log_benchmark_v2 test when CONFIG_LOG_PRINTK=y #34559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordic-krch
added
area: Logging
bug
Arguments for UTIL_CAT were accidentaly concatenated instead of passed separated by comma. Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no>
When printk is redirected to the logging it is using level 0. Level 0 was missing a define used for detection of function prefix use which lead to compilation failure when logging v2 was used with CONFIG_LOG_PRINTK=y. Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no>
nordic-krch
force-pushed
the
fix/logging_0_func_prefix
branch
from
4948764 to
8885a7b
Compare
dcpleung
approved these changes
Apr 26, 2021
carlescufi
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing failing test.
Fixes #34526.
Fixes #34558.