logging: Increase thread stack size when net backend in use #34573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been seen that when net backend is enabled stack usage is around 1080. Setting 1152 as the default. Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no>
|
@aunsbjerg can you try this fix and see if it helps? I've been only able to run it on |
|
@nordic-krch thank you for the fix. Can confirm that this PR fixes the issue. Tested on a |
jukkar
approved these changes
Apr 26, 2021
ioannisg
reviewed
Apr 26, 2021
| default 2048 if (RISCV && 64BIT) | ||
| default 2048 if LOG_BACKEND_FS | ||
| default 1152 if LOG_BACKEND_NET |
There was a problem hiding this comment.
just a note that in CONFIG_USERSPACE builds on ARMv7-M, this gets rounded up to 2048
dcpleung
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been seen that when net backend is enabled stack usage
is around 1080. Setting 1152 as the default.
Fixes #34515.
Signed-off-by: Krzysztof Chruscinski krzysztof.chruscinski@nordicsemi.no