tests: condvar_api: fix permissions to multiple condvar #34778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The permission to use multiple_condvar is not granted to test test_condvar_multiple_threads_wait_wake, which results in bunch or permission error messages, and actually not testing the conditional variables. This grants the permission to the those conditional variables to the test threads. Also, replace the k_yield() with k_msleep() to allow all created threads time to run. A simply k_yield() might let a few to run before the next batch of "waking" threads start to run, resulting in some conditional variables not being initialized but trying to wake. Fixes zephyrproject-rtos#34777 Signed-off-by: Daniel Leung <daniel.leung@intel.com>
github-actions
bot
added
area: Kernel
area: Tests
nashif
approved these changes
May 3, 2021
enjiamai
approved these changes
May 3, 2021
This adds k_thread_join() to the thread being used in test_sem_take_timeout_isr() to avoid a thread re-use error in the test after this one. Signed-off-by: Daniel Leung <daniel.leung@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The permission to use multiple_condvar is not granted to test
test_condvar_multiple_threads_wait_wake, which results in
bunch or permission error messages, and actually not testing
the conditional variables. This grants the permission to
the those conditional variables to the test threads. Also,
replace the k_yield() with k_msleep() to allow all created
threads time to run. A simply k_yield() might let a few to
run before the next batch of "waking" threads start to run,
resulting in some conditional variables not being initialized
but trying to wake.
Fixes #34777
Signed-off-by: Daniel Leung daniel.leung@intel.com