Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples: sensor: Fix logically dead code in adxl372 and bmg160 samples #35192

Merged
merged 2 commits into from
May 12, 2021
Merged

samples: sensor: Fix logically dead code in adxl372 and bmg160 samples #35192

merged 2 commits into from
May 12, 2021

Conversation

MaureenHelm
Copy link
Member

@MaureenHelm MaureenHelm commented May 12, 2021 •
edited
Loading

Converts the adxl372 and bmg160 sample applications to check the sensor device at
build time instead of runtime. This fixes Coverity issues for logically
dead code introduced in #34589.

Fixes #35118
Fixes #35119

@MaureenHelm
samples: sensor: Fix logically dead code in adxl372 sample
e986d8b 
Converts the adxl372 sample application to check the sensor device at
build time instead of runtime. This fixes a Coverity issue for logically
dead code introduced in commit 72795c3.

Fixes #35119
Coverity-CID: 235932

Signed-off-by: Maureen Helm <maureen.helm@nxp.com>
@MaureenHelm
samples: sensor: Fix logically dead code in bmg160 sample
95b7381 
Converts the bmg160 sample application to check the sensor device at
build time instead of runtime. This fixes a Coverity issue for logically
dead code introduced in commit 5832e58.

Fixes #35118
Coverity-CID: 235919

Signed-off-by: Maureen Helm <maureen.helm@nxp.com>
@MaureenHelm MaureenHelm added the bug The issue is a bug, or the PR is fixing a bug label May 12, 2021
@MaureenHelm MaureenHelm added this to the v2.6.0 milestone May 12, 2021
@github-actions github-actions bot added the area: Samples Samples label May 12, 2021
@galak galak merged commit 19fd583 into zephyrproject-rtos:master May 12, 2021
@MaureenHelm MaureenHelm deleted the sensor-logically-dead-code branch May 12, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfischer-no jfischer-no jfischer-no approved these changes

@nashif nashif nashif approved these changes

@galak galak Awaiting requested review from galak

@mbolivar-nordic mbolivar-nordic Awaiting requested review from mbolivar-nordic

Assignees
No one assigned
Labels
area: Samples Samples bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Milestone
v2.6.0
4 participants
@MaureenHelm @nashif @jfischer-no @galak