tests: kernel/common: incorrect use of k_poll in timeout order #35275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: Kernel
area: Tests
nashif
reviewed
May 14, 2021
In the timeout order test, the usage of k_poll() assumes that it only returns after all events are ready. However, that is not the case, as k_poll() returns when non-zero number of events are ready. This means the check for all semaphore being ready after k_poll() will not always pass. So instead of using k_poll(), simply wait a bit for timers to fire, then check results. Also add some bits to clean up at the end of test. Fixes zephyrproject-rtos#34585 Signed-off-by: Daniel Leung <daniel.leung@intel.com>
dcpleung
force-pushed
the
tests_kernel_common_timeout_order_fix
branch
from
dec4cfa to
338cf9a
Compare
Oops... updated. |
nashif
approved these changes
May 21, 2021
enjiamai
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the timeout order test, the usage of k_poll() assumes that it
only returns after all events are ready. However, that is not
the case, as k_poll() returns when non-zero number of events are
ready. This means the check for all semaphore being ready after
k_poll() will not always pass. So instead of using k_poll(),
simply wait a bit for timers to fire, then check results.
Also add some bits to clean up at the end of test.
Fixes #34585
Signed-off-by: Daniel Leung daniel.leung@intel.com