Bluetooth: controller: Fix data length calculation in adv report #35453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrzej-kaczmarek
requested review from
carlescufi,
cvinayak,
kruithofa and
thoh-ot
as code owners
cvinayak
requested changes
May 20, 2021
Max data length has to be adjusted for subevent code, otherwise we'll hit an assert when trying to add data to event due to insufficient free space. Signed-off-by: Andrzej Kaczmarek <andrzej.kaczmarek@codecoup.pl>
andrzej-kaczmarek
force-pushed
the
fix-hci-adv-data-len
branch
from
9b0f85f to
0e4ca7c
Compare
Fix the missing HCI event data len limit check when encoding incomplete advertising data report. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
andrzej-kaczmarek
force-pushed
the
fix-hci-adv-data-len
branch
from
0e4ca7c to
2be9cf0
Compare
cvinayak
approved these changes
May 21, 2021
carlescufi
approved these changes
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Max data length has to be adjusted for subevent code, otherwise we'll
hit an assert when trying to add data to event due to insufficient
free space.
Fixes #35344.
Signed-off-by: Andrzej Kaczmarek andrzej.kaczmarek@codecoup.pl