Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: scripts: gen_devicetree_rest: use utf-8 encoding #35470

Merged
merged 1 commit into from
May 20, 2021

Conversation

gmarull
Copy link
Member

@gmarull gmarull commented May 19, 2021

Use utf-8 encoding when opening vendor prefix files. Note that utf-8 is enforced in other scripts, e.g. gen_kconfig_rest, gen_helpers, etc.

Fixes #34076

Alternative to #35234

Use utf-8 encoding when opening vendor prefix files.

Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
@gmarull gmarull requested a review from carlescufi as a code owner May 19, 2021 15:55
@gmarull gmarull requested review from mbolivar-nordic and galak May 19, 2021 15:56
@gmarull gmarull added the bug The issue is a bug, or the PR is fixing a bug label May 19, 2021
@gmarull gmarull requested a review from nashif May 19, 2021 15:58
@mbolivar-nordic
Copy link
Contributor

There was another issue related to breathe mentioned in #34076 which I think neither this nor #35234 addresses:

#34076 (comment)

Any idea where that I/O error is happening?

@gmarull
Copy link
Member Author

gmarull commented May 19, 2021

There was another issue related to breathe mentioned in #34076 which I think neither this nor #35234 addresses:

#34076 (comment)

Any idea where that I/O error is happening?

breathe is responsible of handling Doxygen XML files. Since Doxygen seems to process input in UTF-8, I imagine it's breathe not reading XML files using UTF-8 on Windows. Some suspicious stuff: https://github.com/michaeljones/breathe/search?q=ascii

@galak galak merged commit 5738114 into zephyrproject-rtos:main May 20, 2021
@gmarull gmarull deleted the fix/dt-utf8 branch January 18, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unrecognized characters generated during document construction
3 participants