Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toolchain: arcmwdt: linker: fix placeholders for arcmwdt toolchain #35488

Conversation

IRISZZW
Copy link
Contributor

@IRISZZW IRISZZW commented May 20, 2021

syntax ". += length;" not work with arcmwdt toolchain, let's using
". = . + length;", which both work with gnu and arcmwdt toolchain.

Signed-off-by: Watson Zeng zhiwei@synopsys.com

Fix: #35479

syntax ". += length;" not work with arcmwdt toolchain, let's using
". = . + length;", which both work with gnu and arcmwdt toolchain.

Signed-off-by: Watson Zeng <zhiwei@synopsys.com>
@IRISZZW IRISZZW requested review from andyross and nashif as code owners May 20, 2021 07:03
@github-actions github-actions bot added the area: API Changes to public APIs label May 20, 2021
@IRISZZW IRISZZW added the area: ARC ARC Architecture label May 20, 2021
@IRISZZW IRISZZW added this to the v2.6.0 milestone May 20, 2021
Copy link
Member

@stephanosio stephanosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, this patch should be accompanied by an automated check that prevents use of symbol f= expression, where f is any supported operator, in the linker scripts.

@IRISZZW
Copy link
Contributor Author

IRISZZW commented May 20, 2021

Ideally, this patch should be accompanied by an automated check that prevents use of symbol f= expression, where f is any supported operator, in the linker scripts.

@stephanosio Is there any similar design that I can take a reference? And I think your ideal should be an enhancement, maybe we can add it in v2.7.0.

@galak galak added the bug The issue is a bug, or the PR is fixing a bug label May 20, 2021
@stephanosio
Copy link
Member

Is there any similar design that I can take a reference? And I think your ideal should be an enhancement, maybe we can add it in v2.7.0.

@IRISZZW Possibly, we can update checkpatch.pl to do just that in the future; or alternatively, make arcmwdt generate errors when an unsupported statement is encountered; or, even better, make arcmwdt support +=.

Copy link
Member

@ruuddw ruuddw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, I think it is not just the Metaware linker than doesn't like this, clang/llvm linker and others might not either.

@galak galak merged commit 214d91c into zephyrproject-rtos:main May 20, 2021
@IRISZZW IRISZZW deleted the topic-mwdt-linker-script-fix branch May 31, 2021 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: API Changes to public APIs area: ARC ARC Architecture bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

address is not a known kernel object exception with arcmwdt toolchain
6 participants