-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
toolchain: arcmwdt: linker: fix placeholders for arcmwdt toolchain #35488
toolchain: arcmwdt: linker: fix placeholders for arcmwdt toolchain #35488
Conversation
syntax ". += length;" not work with arcmwdt toolchain, let's using ". = . + length;", which both work with gnu and arcmwdt toolchain. Signed-off-by: Watson Zeng <zhiwei@synopsys.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, this patch should be accompanied by an automated check that prevents use of symbol f= expression
, where f
is any supported operator, in the linker scripts.
@stephanosio Is there any similar design that I can take a reference? And I think your ideal should be an enhancement, maybe we can add it in v2.7.0. |
@IRISZZW Possibly, we can update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, I think it is not just the Metaware linker than doesn't like this, clang/llvm linker and others might not either.
syntax ". += length;" not work with arcmwdt toolchain, let's using
". = . + length;", which both work with gnu and arcmwdt toolchain.
Signed-off-by: Watson Zeng zhiwei@synopsys.com
Fix: #35479