drivers/spi: stm32: Revert while loop on tx only #35661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ABOSTM
requested changes
May 26, 2021
erwango
requested changes
May 26, 2021
There was a problem hiding this comment.
Please fix commit title. For instance:
"drivers/spi: stm32: Revert while loop on tx only"
Also please don't abuse of github references:
"This commit will solve issue created after #34731.
This commit removes all th regression that caused due to commit #34731."
It's good to add links but it should be done in addition to explicit comments.
affrinpinhero-2356
changed the title
okay. |
affrinpinhero-2356
force-pushed
the
spiBugFix-#34731
branch
4 times, most recently
from
e3a7aa2 to
74ccbc7
Compare
This commit reverted while loop on tx only. This commit solves SPI loopback failure and SPI wrong behaviour on RX. fix: * zephyrproject-rtos#35297 * zephyrproject-rtos#35539 Revert "drivers/spi: STM32: This solves SPI infinite loop on Tranceive" This reverts commit 50c2acb. Signed-off-by: Affrin Pinhero <affrin.pinhero@hcl.com>
affrinpinhero-2356
force-pushed
the
spiBugFix-#34731
branch
from
74ccbc7 to
0ccf4a3
Compare
erwango
approved these changes
May 26, 2021
This was referenced May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reverted while loop on tx only.
This commit solves SPI loopback failure and SPI wrong behaviour on RX.
fix:
Revert "drivers/spi: STM32: This solves SPI infinite loop on Tranceive"
This reverts commit 50c2acb.
Signed-off-by: Affrin Pinhero affrin.pinhero@hcl.com