Fix hanging dtls handshake if no reply #35712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emillindq
force-pushed
the
dtls_lte_nohang
branch
from
a885f0e to
194c569
Compare
emillindq
force-pushed
the
dtls_lte_nohang
branch
from
194c569 to
71dda19
Compare
jukkar
approved these changes
May 27, 2021
| @@ -563,9 +563,8 @@ static int dtls_rx(void *ctx, unsigned char *buf, size_t len, | |||
| uint32_t dtls_timeout) | |||
There was a problem hiding this comment.
Can you add the "Fixes #35541" to the commit body of "net: sockets: tls: check return code from fcntl " commit so it is easier to track what commit fixes what issue.
Not checking return code in fcntl can result in interpreting -1 as flags, and cause unexpected behaviour. Fixes zephyrproject-rtos#35541 Signed-off-by: Emil Lindqvist <emil@lindq.gr>
Zephyr sees fnctl as an alias of ioctl, and so the F_GETFL request should be handled here as well. Signed-off-by: Emil Lindqvist <emil@lindq.gr>
emillindq
force-pushed
the
dtls_lte_nohang
branch
from
71dda19 to
ddcf465
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35541