Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: support ZephyrBuildConfiguration_ROOT for package location #35902

Conversation

tejlmand
Copy link
Collaborator

@tejlmand tejlmand commented Jun 3, 2021

Fixes: #35890

The current implementation of Zephyr build configuration CMake package
only allows the build configuration package to be placed inside a
Zephyr workspace.

This commit extends the usability by allowing users to locate the
Zephyr build configuration CMake package outside the Zephyr workspace
and then refer to the package using
-DZephyrBuildConfiguration_ROOT=<path>
set(ZephyrBuildConfiguration_ROOT <path>)

This allows users greater flexibility in their workspace layouts.

Signed-off-by: Torsten Rasmussen Torsten.Rasmussen@nordicsemi.no

Fixes: zephyrproject-rtos#35890

The current implementation of Zephyr build configuration CMake package
only allows the build configuration package to be placed inside a
Zephyr workspace.

This commit extends the usability by allowing users to locate the
Zephyr build configuration CMake package outside the Zephyr workspace
and then refer to the package using
`-DZephyrBuildConfiguration_ROOT=<path>`
`set(ZephyrBuildConfiguration_ROOT <path>)`

This allows users greater flexibility in their workspace layouts.

Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
@tejlmand tejlmand added the bug The issue is a bug, or the PR is fixing a bug label Jun 3, 2021
@tejlmand tejlmand requested a review from nashif as a code owner June 3, 2021 08:55
@tejlmand tejlmand added this to the v2.6.0 milestone Jun 3, 2021
Update to the Zephyr build configuration CMake package documentation
with description on how a Zephyr build configuration CMake package can
be located outside a Zephyr workspace.

Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
@tejlmand tejlmand force-pushed the issues/35890_ZephyrBuildConfiguration_ROOT branch from 437891b to ecf6ea8 Compare June 3, 2021 08:57
@galak galak added the priority: high High impact/importance bug label Jun 4, 2021
Copy link
Contributor

@mbolivar-nordic mbolivar-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for docs

@galak galak removed the priority: high High impact/importance bug label Jun 4, 2021
@galak galak merged commit e08a7f5 into zephyrproject-rtos:main Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Build System area: Documentation bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build system ignores explicit ZephyrBuildConfiguration_ROOT variable
4 participants