Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluetooth: Enforce cooperative priorities in Bluetooth threads #502

Merged
merged 1 commit into from
Jun 15, 2017

Conversation

carlescufi
Copy link
Member

The Bluetooth subsystem assumes execution of its system threads in
cooperative priority, including the system workqueue and the thread
that interact with the controller (i.e. calling bt_send). This commit
adds a compile-time check for the system workqueue priority and
documentation for the bt_send API call.

Signed-off-by: Carles Cufi carles.cufi@nordicsemi.no

@carlescufi carlescufi requested review from cvinayak and jhedberg June 15, 2017 08:50
The Bluetooth subsystem assumes execution of its system threads in
cooperative priority, including the system workqueue and the thread
that interact with the controller (i.e. calling bt_send). This commit
adds a compile-time check for the system workqueue priority and
documentation for the bt_send API call.

Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
Copy link
Member

@jhedberg jhedberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fairly good. I'm not 100% sure of the dummy.c file name, but can't think of anything better either right now. I'll wait for one other review.

@jhedberg jhedberg merged commit 7d075f5 into zephyrproject-rtos:master Jun 15, 2017
nagineni pushed a commit to nagineni/zephyr that referenced this pull request Nov 20, 2017
…ephyrproject-rtos#502)

Because printf was being used, the % character would have needed special
treatment to avoid a warning.

Also, the dots were overflowing past the end of the line in output which
looked bad after it hit 90%.

Fixes issue zephyrproject-rtos#490.

Signed-off-by: Geoff Gustafson <geoff@linux.intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants