mgmt: mcumgr: Deprecate returning rc responses when status is OK. #51555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordicjm
requested review from
nashif,
carlescufi and
de-nordic
as code owners
zephyrbot
added
Release Notes
nordicjm
force-pushed
the
mcurc
branch
2 times, most recently
from
98c44d1 to
b4c8a0c
Compare
de-nordic
requested changes
Nov 17, 2022
de-nordic
previously approved these changes
Nov 23, 2022
carlescufi
approved these changes
Dec 5, 2022
carlescufi
requested changes
Dec 5, 2022
With this change it's more to give users the choice to revert as some software that uses that might be unable to cope with the change, and they might need time to adapt the software. |
Yes, but @nordicjm mentions important issue of no-Zephyr based tools, that may require some time to adapt. |
carlescufi
requested changes
Dec 13, 2022
This change changes the previous mcumgr behaviour of return result codes when the status is 0 (OK) to being legacy behaviour, instead it will skip the rc field for these responses. If there is only an rc field with status 0 to return, then mcumgr will now instead just return an empty map. Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Adds a note on rc responses to mcumgr commands where the status is good that these responses will henceforth be emitted. Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Updates documentation on when the rc response is returned. Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
de-nordic
approved these changes
Dec 14, 2022
|
@carlescufi Please take another look. Thanks. |
carlescufi
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change deprecates the previous mcumgr behaviour of return result codes when the status is 0 (OK), instead it will skip the rc field for these responses. If there is only an rc field with status 0 to return, then mcumgr will now instead just return an empty map.
Fixes #42590