posix: abstract pthread_key_t as uint32_t #52313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfriedt
requested review from
enjiamai,
stephanosio,
jeremybettis and
KangJianX
cfriedt
force-pushed
the
use-uint32-for-pthread-key
branch
from
57034dd to
8b6b10c
Compare
|
Compliance failure is a false positive (pthread functions return non-negative errno values, not introducing any new types). |
cfriedt
changed the title
cfriedt
changed the title
This was referenced Nov 17, 2022
jeremybettis
previously approved these changes
Nov 18, 2022
Since this lock is only used in `pthread_once()` it makes sense to name it accordingly. Signed-off-by: Chris Friedt <cfriedt@meta.com>
None of the operations that `pthread_key_sem` protected were blocking, so simply make it a spinlock. Also made the lock static. Signed-off-by: Chris Friedt <cfriedt@meta.com>
cfriedt
force-pushed
the
use-uint32-for-pthread-key
branch
from
8b6b10c to
9093e8e
Compare
|
Consistent with the change of `pthread_t`, `pthread_mutex_t`, and `pthread_cond_t` to `uint32_t`, we can now also abstract `pthread_key_t` as `uint32_t` and separate the implementation detail, hidden from POSIX API consumers. This change introduces `CONFIG_MAX_PTHREAD_KEY_COUNT`. Signed-off-by: Chris Friedt <cfriedt@meta.com>
cfriedt
force-pushed
the
use-uint32-for-pthread-key
branch
from
9093e8e to
4f1f47d
Compare
|
|
@jeremybettis - are you OK to re-ACK? |
|
@enjiamai @KangJianX @keith-packard @stephanosio - would gratefully accept an approval if anyone is feeling generous 😁 |
jeremybettis
approved these changes
Nov 22, 2022
mbolivar-nordic
approved these changes
Nov 23, 2022
stephanosio
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 commits:
Please see each commit message for details.