[Backport v3.2-branch] lib: posix: make sleep() and usleep() standards-compliant #52545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `usleep()` for >= 10000000 microseconds results in an error, so this test was kind of defective, having explicitly called `usleep()` for seconds. Also, check the return values of `clock_gettime()`. Signed-off-by: Chris Friedt <cfriedt@meta.com> (cherry picked from commit 23a1f0a)
In the case that `sleep()` is interrupted, the POSIX spec requires it to return the number of "unslept" seconds (i.e. the number of seconds requested minus the number of seconds actually slept). Since `k_sleep()` already returns the amount of "unslept" time in ms, we can simply use that. Signed-off-by: Chris Friedt <cfriedt@meta.com> (cherry picked from commit dcfcc64)
The original implementation of `usleep()` was not compliant to the POSIX spec in 3 ways. - calling thread may not be suspended (because `k_busy_wait()` was previously used for short durations) - if `usecs` > 1000000, previously we did not return -1 or set `errno` to `EINVAL` - if interrupted, previously we did not return -1 or set `errno` to `EINTR` This change addresses those issues to make `usleep()` more POSIX-compliant. Signed-off-by: Chris Friedt <cfriedt@meta.com> (cherry picked from commit 7b95428)
Previously, there was no test coverage for `sleep()` and `usleep()`. This change adds full test coverage. Signed-off-by: Chris Friedt <cfriedt@meta.com> (cherry picked from commit 027b79e)
Codecov Report
@@ Coverage Diff @@
## v3.2-branch #52545 +/- ##
==============================================
Coverage ? 50.53%
==============================================
Files ? 711
Lines ? 89949
Branches ? 21250
==============================================
Hits ? 45455
Misses ? 36793
Partials ? 7701 Continue to review full report at Codecov.
|
stephanosio
approved these changes
Nov 27, 2022
enjiamai
approved these changes
Nov 28, 2022
fabiobaltieri
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 027b79e~4..027b79e from #52519
Fixes #51776
Fixes #52517
Fixes #52518