samples: Bluetooth: Update Readme of large MTU sample #53830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
alwa-nordic,
asbjornsabo,
hermabe,
jhedberg,
jori-nordic,
sjanc,
Thalley and
Vudentz
jori-nordic
reviewed
Jan 16, 2023
Update the Readme file of the large mtu sample because the orginal PR (zephyrproject-rtos#53593) has been merged before the last comment could be addressed. Signed-off-by: Théo Battrel <theo.battrel@nordicsemi.no>
theob-pro
force-pushed
the
update-readme-mtu-sample
branch
from
f6b4bc0 to
0e6e210
Compare
|
Why are we adding this text only specifically for this sample? A lot of our connection samples have RSSI filtering |
We are just clarifying text that is already there. |
Ah, sorry, had missed that this sample already had text w.r.t. this. |
Thalley
approved these changes
Jan 16, 2023
jhedberg
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Readme file of the large mtu sample because the orginal PR (#53593) has been merged before the last comment (#53593 (comment)) could be addressed.