Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mtl: bugfix: tlb driver should allow remapping all unused pages, including one at UNUSED_L2_START_ALIGNED address #54278

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

marcinszkudlinski
Copy link
Collaborator

@marcinszkudlinski marcinszkudlinski commented Jan 31, 2023

UNUSED_L2_START_ALIGNED is a marker of first page not used by the linker. Starting from this page, the memory may be re-mapped. assertion <= is banning remapping of the first unused page changing to <

Defect reproduces when assertions are enabled

Fixes #54410

UNUSED_L2_START_ALIGNED is a marker of first page not used by the
linker. Starting from this page, the memory may be re-mapped.
assertion <= is banning remapping of the first unused page
changing to <

Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
@marcinszkudlinski marcinszkudlinski added the platform: Intel ADSP Intel Audio platforms label Feb 1, 2023
@nashif nashif added this to the v3.3.0 milestone Feb 1, 2023
@stephanosio
Copy link
Member

@marcinszkudlinski A bug report is required in order for this PR to be merged during the feature freeze. Please file a bug report issue for the problem that this PR is trying to fix and link the issue to this PR.

@marcinszkudlinski
Copy link
Collaborator Author

Bug report:
#54410

@marcinszkudlinski
Copy link
Collaborator Author

@stephanosio @nashif pls merge, the fix does not affect anything but MTL TLB

@marcinszkudlinski marcinszkudlinski added the bug The issue is a bug, or the PR is fixing a bug label Feb 3, 2023
@stephanosio stephanosio merged commit 44222b7 into zephyrproject-rtos:main Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Memory Management bug The issue is a bug, or the PR is fixing a bug platform: Intel ADSP Intel Audio platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] TLB driver fails to unmap L2 HPSRAM region when assertions are enabled
10 participants