dma: dw: allow to stop in DW_DMA_SUSPENDED state #54900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The conditional definitions are not correct as "chan_data" is used without any include guards, but defined only if CONFIG_DMA_DW_HW_LLI or CONFIG_DMA_DW_SUSPEND_DRAIN is defined. Correct the declaration to match usage. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Allow DMA channel to be stopped even if it is in suspended state. The current code in dw_dma_stop() supports this, but the recently added early check for dw_dma_is_enabled() results in DMA stop sequence to be skipped if the channel was in suspended state. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
softwarecki
approved these changes
Feb 16, 2023
teburd
approved these changes
Feb 16, 2023
kv2019i
added a commit
to kv2019i/sof
that referenced
this pull request
Feb 16, 2023
Update Zephyr to latest version plus cherry-pick PR54900 zephyrproject-rtos/zephyr#54900 on top. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
tmleman
approved these changes
Feb 16, 2023
abonislawski
approved these changes
Feb 17, 2023
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dma: dw: allow to stop in DW_DMA_SUSPENDED state
Without this fix, current Zephyr main fails most SOF test cases where DW_DMA is used.