[Backport v2.7] tests: posix: pthread: init pthread_attr_t on each iteration #57413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: POSIX
cfriedt
force-pushed
the
backport-57403-to-v2.7-branch
branch
from
acc9b98 to
cf9d0f8
Compare
cfriedt
force-pushed
the
backport-57403-to-v2.7-branch
branch
from
cf9d0f8 to
3a132f6
Compare
The `test_pthread_descriptor_leak` test was causing a kernel panic on some platforms. Initially, it was not clear why. The usual cases were examined - race conditions, stack sizes, etc. Still no luck. As it turns out, recycling a thread stack (or at least the `pthread_attr_t`) in-place does not work on some platforms, and we need to reinitialize the `pthread_attr_t` and set set the stack property again prior to calling `pthread_create()`. Signed-off-by: Christopher Friedt <cfriedt@meta.com> (cherry picked from commit 7c17bda)
Rather than pass an variable address to a `void *` in `pthread_join()` and do nothing with it, just pass `NULL`. Signed-off-by: Christopher Friedt <cfriedt@meta.com> (cherry picked from commit 12ed08a)
cfriedt
force-pushed
the
backport-57403-to-v2.7-branch
branch
from
3a132f6 to
99741c8
Compare
jgl-meta
approved these changes
May 1, 2023
|
Can we please be a bit more descriptive in PR titles? |
nashif
changed the title
|
This does not solve the actual problem. Additional details in #56163 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 7c17bda..12ed08a from #57403
Fixes #56163