posix: implement clock_getres() #60187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address missing POSIX functions and test zephyrproject-rtos#59955 Signed-off-by: Harshil Bhatt <harshilbhatt2001@gmail.com>
ycsin
reviewed
Jul 10, 2023
| @@ -36,6 +37,12 @@ ZTEST(posix_apis, test_clock) | |||
| secs_elapsed = (te.tv_sec - ts.tv_sec - 1); | |||
| } | |||
|
|
|||
| ret = clock_getres(CLOCK_MONOTONIC, &te); | |||
| zassert_equal(ret, 0, "Fail to get monotonic clock resolution"); | |||
There was a problem hiding this comment.
can use zassert_ok to avoid declaring ret
| tick_2 = k_uptime_ticks(); | ||
| } | ||
|
|
||
| int tick_res = tick_2 - tick_1; |
There was a problem hiding this comment.
tv_nsec is in long, this prob can use long as well?
cfriedt
requested changes
Jul 10, 2023
There was a problem hiding this comment.
This function will need to tie in to specific hardware. Part of the LTSv3 Roadmap is to rework clocks, add device tree chosen nodes for RTC and monotonic, and provide a means of querying the precision of the HW clock resolution.
All of that should be done in Zephyr so that the POSIX layer is just a thin wrapper.
Clock getres should likely come after all of that is done..
|
Should this be closed, then? |
|
Probably for now, but I appreciate the effort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address missing POSIX functions and test #59955