usb: stm32: fix FIFO allocation sizes #70795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
ABOSTM,
Desvauxm-st,
erwango,
FRASTM,
gautierg-st,
GeorgeCGV,
jfischer-no and
tmon-nordic
arbrauns
commented
Mar 27, 2024
drivers/usb/device/usb_dc_stm32.c
Outdated
| @@ -132,12 +132,13 @@ static const struct gpio_dt_spec ulpi_reset = | |||
|
|
|||
| /* We need a minimum size for RX FIFO */ | |||
| #define USB_FIFO_RX_MIN 160 | |||
There was a problem hiding this comment.
The original PR (#62530) doesn't explain where this number comes from, and doesn't clarify whether it is supposed to be bytes or words. @Desvauxm-st?
There was a problem hiding this comment.
Judging by #69897, it's probably supposed to be words, updated accordingly.
There was a problem hiding this comment.
FYI @Desvauxm-st is now enjoying his retirement. @marwaiehm-st will have a look.
The RX FIFO size is in words, so needs to be subtracted from the total memory size *after* it's divided by 4. Fixes zephyrproject-rtos#70789. Signed-off-by: Armin Brauns <armin.brauns@embedded-solutions.at>
Magic constants throughout the code made this difficult to reason about, especially with two different units of measurement (bytes and words) at play. Signed-off-by: Armin Brauns <armin.brauns@embedded-solutions.at>
arbrauns
force-pushed
the
stm32-usb-fix-rx-fifo-min-size
branch
from
550fbcc
to
2e15d39
Compare
|
LGTM |
erwango
approved these changes
Apr 3, 2024
marwaiehm-st
approved these changes
Apr 3, 2024
tmon-nordic
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages.
Fixes #70789.