drivers: sam_can: fixed MCAN Register Base Address #73594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Devicetree Binding
zephyrbot
requested review from
alexanderwachter,
attie-argentum,
decsny,
henrikbrixandersen,
martinjaeger,
mnkp,
pdgendt,
stephanosio and
str4t0m
henrikbrixandersen
requested changes
May 31, 2024
should be ready, as expected |
henrikbrixandersen
requested changes
Jun 1, 2024
|
@henrikbrixandersen ... understood, I will make the changes according your requestes. |
tswaehn
force-pushed
the
test
branch
2 times, most recently
from
b4a6be1 to
a938238
Compare
henrikbrixandersen
requested changes
Jun 11, 2024
|
@tswaehn Ping? |
|
@tswaehn Do you plan to return to this PR? Zephyr v3.7.0 deadline for bug fixes is getting close. I'd like to see this one included. |
yes, I will try to get it done. |
tswaehn
force-pushed
the
test
branch
3 times, most recently
from
d32fa43 to
4fde5d1
Compare
|
I think, I covered all requested changes. |
tswaehn
force-pushed
the
test
branch
2 times, most recently
from
0da55c6 to
51d2644
Compare
alexanderwachter
previously approved these changes
Jun 27, 2024
Before that fix, the default mrba was used; added DMA Base Address to DTSI. Fixes zephyrproject-rtos#68472 Signed-off-by: Sven Ginka <sven.ginka@gmail.com>
alexanderwachter
approved these changes
Jun 27, 2024
henrikbrixandersen
approved these changes
Jun 27, 2024
nandojve
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before that fix, the default mrba was used; additionally the offset of "0" to the actual mcan memory location was used.
Fixes #68472