Drivers: DAI: Intel: Capture corruption risk fix and code improve patches for ACE DMIC #74414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dai_dmic_update_bits() function is used in start trigger code dai_dmic_start() and in capture runtime to control DMIC IP in unmute sequence. Especially the start sequence is timing critical so it's better not produce additional delay in this function. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This patch removes the traces printed inside spinlock protected code. The DMIC capture start code is timing critical. Traces leave an unknown delay into start sequence, so it's better to not produce them. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
The unreset of ACE PDM controllers is moved to beginning of void dai_dmic_start() and done side-by-side. This change is done for adhering to recommended hardware initialization flow to avoid intermittent failures on ARL-S. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
requested review from
marcinszkudlinski and
abonislawski
as code owners
zephyrbot
requested review from
dbaluta,
iuliana-prodan,
juimonen,
kv2019i and
lgirdwood
kv2019i
approved these changes
Jun 18, 2024
lyakh
approved these changes
Jun 18, 2024
kv2019i
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.