Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: wifi: Fix the nm type check error #75982

Merged
merged 1 commit into from
Jul 27, 2024
Merged

net: wifi: Fix the nm type check error #75982

merged 1 commit into from
Jul 27, 2024

Conversation

MaochenWang1
Copy link
Collaborator

Fix the NM iface type check error, should use (1 << WIFI_TYPE_STA),
instead of WIFI_TYPE_STA. Same for WIFI_TYPE_SAP.

@zephyrbot zephyrbot requested review from jukkar, krish2718 and rlubos July 17, 2024 05:59
@MaochenWang1
net: wifi: Fix the nm type check error
a1b8f34 
Fix the NM iface type check error, should use (1 << WIFI_TYPE_STA),
instead of WIFI_TYPE_STA. Same for WIFI_TYPE_SAP.

Signed-off-by: Maochen Wang <maochen.wang@nxp.com>
@MaochenWang1 MaochenWang1 changed the title subsys: net: wifi: Fix the nm type check error net: wifi: Fix the nm type check error Jul 17, 2024
jukkar
jukkar approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@jukkar jukkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should convert all the recently introduced (1 << xyz) statements in wifi to BIT(xyz) in a following PR as using BIT macro is much more readable. I would not mind if someone sends a PR for that.

@jukkar jukkar added the backport v3.7-branch Request backport to the v3.7-branch label Jul 17, 2024
@nashif nashif merged commit bf42164 into zephyrproject-rtos:main Jul 27, 2024
27 checks passed
@zephyrbot zephyrbot mentioned this pull request Jul 27, 2024
Merged
@M-Haziq94 M-Haziq94 mentioned this pull request Aug 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krish2718 krish2718 krish2718 approved these changes

@rlubos rlubos rlubos approved these changes

@jukkar jukkar jukkar approved these changes

Assignees

@jukkar jukkar

Labels
area: Networking area: Wi-Fi Wi-Fi backport v3.7-branch Request backport to the v3.7-branch
Projects
Wi-Fi
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MaochenWang1 @jukkar @rlubos @krish2718 @nashif @zephyrbot