modules: tf-m: fix git clone during build #76094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-trusted-firmware-m
DNM
tomi-font
added
bug
tomi-font
added
the
Release Blocker
Vge0rge
previously approved these changes
Jul 19, 2024
valeriosetti
previously approved these changes
Jul 19, 2024
ithinuel
previously approved these changes
Jul 19, 2024
|
Module PR: zephyrproject-rtos/trusted-firmware-m#109 |
cfriedt
previously approved these changes
Jul 22, 2024
dkalowsk
previously approved these changes
Jul 23, 2024
|
@nashif not sure if this was discussed for 3.7 inclusion but figured I'd tag you to make sure the decision is documented |
d3zd3z
previously approved these changes
Jul 24, 2024
|
Added dnm until the module PR is merged, and this PR manifest points to a commit in the module and not PR |
|
Thanks @tomi-font, the module PR has been merged. Please update the manifest pointer. |
As of v2.1.0 TF-M has updated to CMSIS v6 and switched from hosting the sources to depending on the upstream repository, cloning it at build time. To prevent a download from happening during the build, CMSIS v6 sources are pushed to Zephyr's fork of TF-M and the `CMSIS_PATH` CMake variable is set to point to them. Signed-off-by: Tomi Fontanilles <tomi.fontanilles@nordicsemi.no>
tomi-font
dismissed stale reviews from d3zd3z, dkalowsk, cfriedt, ithinuel, valeriosetti, and Vge0rge
via
5fd2185
tomi-font
force-pushed
the
tfm_fix_cmsis_clone
branch
from
10d75b3 to
5fd2185
Compare
tomi-font
requested review from
aescolar,
d3zd3z,
cfriedt,
ithinuel,
Vge0rge,
valeriosetti and
dkalowsk
|
Do we also plan on forking the CMSIS v6 repo for after the release? |
valeriosetti
approved these changes
Jul 25, 2024
jhedberg
approved these changes
Jul 25, 2024
ithinuel
approved these changes
Jul 25, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of v2.1.0 TF-M has updated to CMSIS v6 and switched from hosting the sources to depending on the upstream repository, cloning it at build time.
To prevent a download from happening during the build, CMSIS v6 sources are pushed to Zephyr's fork of TF-M and the
CMSIS_PATHCMake variable is set to point to them.Fixes #76090.