Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport v3.7-branch] Bluetooth: Host: Fix compiling PAwR Sync without PAST RX #76355

Merged
merged 1 commit into from
Aug 6, 2024
Merged

[Backport v3.7-branch] Bluetooth: Host: Fix compiling PAwR Sync without PAST RX #76355

merged 1 commit into from
Aug 6, 2024
+2 −0

Conversation

zephyrbot
Copy link
Collaborator

@zephyrbot zephyrbot commented Jul 27, 2024 •
edited by nashif
Loading

Backport e23345b from #76269.

Fixes #76268.

@rugeGerritsen @github-actions
Bluetooth: Host: Fix compiling PAwR Sync without PAST RX
8796a6f 
The function `bt_hci_le_past_received_v2()` is not compiled
in for this configuration, so the reference needs to be removed.

Fixes #76268.

Signed-off-by: Rubin Gerritsen <rubin.gerritsen@nordicsemi.no>
(cherry picked from commit e23345b)
@zephyrbot zephyrbot added Backport Backport PR and backport failure issues area: Bluetooth Host area: Bluetooth labels Jul 27, 2024
hermabe
hermabe approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@hermabe hermabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not really an issue since the spec requires PAST to be supported whenever PAwR is supported, but change is ok.

@Thalley Thalley removed their request for review July 29, 2024 08:43
@nashif nashif merged commit a58e039 into v3.7-branch Aug 6, 2024
31 of 32 checks passed
@nashif nashif deleted the backport-76269-to-v3.7-branch branch August 6, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jori-nordic jori-nordic jori-nordic approved these changes

@hermabe hermabe hermabe approved these changes

@jhedberg jhedberg jhedberg approved these changes

@alwa-nordic alwa-nordic Awaiting requested review from alwa-nordic

@sjanc sjanc Awaiting requested review from sjanc

@theob-pro theob-pro Awaiting requested review from theob-pro

Assignees

@jhedberg jhedberg

@jori-nordic jori-nordic

Labels
area: Bluetooth Host area: Bluetooth Backport Backport PR and backport failure issues
Projects
Backports
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zephyrbot @jhedberg @hermabe @jori-nordic @nashif @rugeGerritsen