Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging: fix log buffer pending while it is definitely full #76926

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

xiaolusu
Copy link
Contributor

The buffer flags MPSC_PBUF_FULL is a shared resource to determine whether the buffer is available. When processing drop messages, the flag will be cleared first and then set, add spin lock protection.

Copy link

Hello @xiaolusu, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@xiaolusu
Copy link
Contributor Author

I think it can solve the problem mentioned here: #75736

@xiaolusu xiaolusu force-pushed the mpsc_pbuf_lock branch 2 times, most recently from 383ae68 to 685a0ad Compare August 15, 2024 07:51
@xiaolusu
Copy link
Contributor Author

Hi, is there some action needed from my side for this pull request? why did the workflow pending?

The buffer flags MPSC_PBUF_FULL is a shared resource to determine
whether the buffer is available. When processing drop messages,
the flag will be cleared first and then set, add spin lock protection.

Signed-off-by: Xiaolu Sun <xiaolu.sun@intel.com>
@nashif nashif merged commit 45705a8 into zephyrproject-rtos:main Aug 23, 2024
23 checks passed
Copy link

Hi @xiaolusu!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

@kwd-doodling kwd-doodling self-requested a review September 18, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants