-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: cmake: limit Zephyr SDK to 0.16.x series for Zephyr 3.7 LTS #80195
RFC: cmake: limit Zephyr SDK to 0.16.x series for Zephyr 3.7 LTS #80195
Conversation
@stephanosio @nashif @keith-packard based on zephyrproject-rtos/sdk-ng#809 (comment) I think it makes sense to place an upper limit on the Zephyr SDK, as we now consider the Zephyr SDK 0.16.x series an LTS. Should we bring this to the TSC ? |
Yes, thanks for implementing this. Though, ultimately, we would want
Not sure if a TSC approval is needed for this change since this more or less is fixing a bug where an incompatible version of SDK is picked up by the Zephyr LTS release. It would be good to mention it at a TSC meeting to raise more awareness, nevertheless. |
Fixes: zephyrproject-rtos#80200 CMake `find_package(<package> <version>)` support the use of ranges, like `1.0.0...4.0.0`. Update the FindZephyr-sdk.cmake module to support this. This allows looking up the Zephyr SDK with an upper boundry, for example `find_package(Zephyr-sdk 0.16...<0.17)`. Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
Zephyr SDK compatibility level 0.16 is now an LTS intended for Zephyr v3.7 LTS. Thus, limit the upper Zephyr SDK lookup to <0.17, so that developers working with Zephyr v3.7 LTS and latest Zephyr main can install both Zephyr SDK 0.16.x along side Zephyr SDK >=0.17 and have the Zephyr SDK 0.16.x series being used for v3.7 LTS development. Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
0dfdc46
to
61a6e32
Compare
but in such case the I believe we should have a Zephyr SDK v1.0.0 release, and actually start using the major version.
as long as we are using versions <1.0.0 then I think it's stretching it a bit to consider it a bug, but guess we're getting into semantics at this point 😉
yep, I was not expecting any push-back on this, but awareness on those kind of changes are usually good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trusting that the cmake bits implement what it says on the tin...
Should this also get backported to 3.6 as it is still active? |
Yes, I think it should. |
6da35a8
into
zephyrproject-rtos:v3.7-branch
Hmn marking backport only works for PRs that are merged to |
Zephyr SDK compatibility level 0.16 is now an LTS intended for
Zephyr v3.7 LTS.
Thus, limit the upper Zephyr SDK lookup to <0.17, so that developers
working with Zephyr v3.7 LTS and latest Zephyr main can install both
Zephyr SDK 0.16.x along side Zephyr SDK >=0.17 and have the Zephyr SDK
0.16.x series being used for v3.7 LTS development.
This PR depends on a manual backport of #80194 which is included in this PR.
Fixes: #80200