Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PermissionsViewer not showing role names. #759

Closed
wants to merge 1 commit into from

Conversation

ShaneMcC
Copy link

@ShaneMcC ShaneMcC commented Apr 3, 2024

Looks like guild.roles is no longer always populated.

@ShaneMcC
Copy link
Author

ShaneMcC commented Apr 3, 2024

This will resolve #758, #757, #755 and #754

@ShaneMcC ShaneMcC force-pushed the ShaneMcC-PermissionsViewer branch from ac93642 to 2549895 Compare April 3, 2024 22:03
@JustOptimize
Copy link

Been using this version for a while now, it's stable and has no issues, how much longer do we need to wait to get this merged to main? @rauenzi

@XxUnkn0wnxX
Copy link

+4 months and still not merged, maybe he has abandoned the plugin?

@zerebos
Copy link
Owner

zerebos commented Sep 16, 2024

In the future, please only modify the source files and not the packed version.

@zerebos zerebos closed this Sep 16, 2024
@ShaneMcC
Copy link
Author

ShaneMcC commented Sep 16, 2024

Thanks for merging/fixing.

I modified the packed version as well because that seemed to be how all your other commits were. I'll remember for future if it's needed again.

@zerebos
Copy link
Owner

zerebos commented Sep 16, 2024

I get how that can be confusing since I tend to do it all in one go. But committing the packed version triggers an update sequence with the BetterDiscord website, and that's something I only want to do after all the fixes are in

@ShaneMcC ShaneMcC deleted the ShaneMcC-PermissionsViewer branch September 17, 2024 00:12
@ShaneMcC
Copy link
Author

Makes sense, noted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants