Skip to content

Commit

Permalink
Prevent "Race" detected in TestAdmin*User (go-gitea#16830)
Browse files Browse the repository at this point in the history
These tests are missing the defer prefix.

Related go-gitea#1441

Signed-off-by: Andrew Thornton <art27@cantab.net>
  • Loading branch information
zeripath authored Aug 27, 2021
1 parent e37342d commit cd8db3a
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions integrations/admin_user_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import (
)

func TestAdminViewUsers(t *testing.T) {
prepareTestEnv(t)
defer prepareTestEnv(t)()

session := loginUser(t, "user1")
req := NewRequest(t, "GET", "/admin/users")
Expand All @@ -27,7 +27,7 @@ func TestAdminViewUsers(t *testing.T) {
}

func TestAdminViewUser(t *testing.T) {
prepareTestEnv(t)
defer prepareTestEnv(t)()

session := loginUser(t, "user1")
req := NewRequest(t, "GET", "/admin/users/1")
Expand All @@ -39,7 +39,7 @@ func TestAdminViewUser(t *testing.T) {
}

func TestAdminEditUser(t *testing.T) {
prepareTestEnv(t)
defer prepareTestEnv(t)()

testSuccessfullEdit(t, models.User{ID: 2, Name: "newusername", LoginName: "otherlogin", Email: "new@e-mail.gitea"})
}
Expand Down

0 comments on commit cd8db3a

Please sign in to comment.