IceUtil::Time::toDateTime() crashes when used on dates 17+ years in the future

[FabioOsorioMoreira]

Version(please complete the following information):

• Ice Version: 3.7.2 and 3.7.5
• OS: Only tested on Windows
• Language: C++

Describe the bug
If you try to use toDateTime to get a readable string on a date that is several years on the future, the function will crash

Expected behavior
It should return a String containing a human readable date

Additional context
Originally found this issue by configuring a sever to use a certificate that expired 40 years in the future. On the client side I tried to access the sender certificate and display information about it (subjectName, expirationDate, etc). The client would crash every time it got to this line: cert->getNotAfter().toDateTime(). If you run it in Debug mode you can see an assert failing in stftime.

[pepone]

Hi Fabio,

Thanks for the bug report, it is a problem with IceUtil::Time::toString implementation

ice/cpp/src/IceUtil/Time.cpp

Line 281 in 4cfc616

time_t time = static_cast<long>(_usec / 1000000);

This cast is bogus, it should cast to time_t I will push a fix tomorrow with a test.

Cheers,
Jose