Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/conflict master #57

Merged
merged 14 commits into from
Dec 13, 2023
Merged

Fix/conflict master #57

merged 14 commits into from
Dec 13, 2023

Commits on Nov 15, 2023

  1. Dev (#47)

    * Added new ERC1271 signature verification logic in Kernel v0.2.3 (#43)
    
    * Added 1271 wrapper
    
    * Update kernel version to 0.2.3
    
    * use kernel name and version from constants in tests
    
    * added delegatecall support (#44)
    
    * session key validator fixed for batch scenario
    
    * test: fuzz testing for batched options include array
    
    * fix: warning removed, forge fmt (#46)
    
    ---------
    
    Co-authored-by: David Eiber <davideiber@gmail.com>
    leekt and de33 authored Nov 15, 2023
    Configuration menu
    Copy the full SHA
    90fa72e View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. Configuration menu
    Copy the full SHA
    160957f View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Added new ERC1271 signature verification logic in Kernel v0.2.3 (#43)

    * Added 1271 wrapper
    
    * Update kernel version to 0.2.3
    
    * use kernel name and version from constants in tests
    de33 authored and leekt committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    bb1f4dc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    218b5e8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    24d9d2f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f0d9bb1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    986c502 View commit details
    Browse the repository at this point in the history
  6. Documentation & minor gas optimisation during userOpExecution (#50)

    * Add storage slot documentation & run coverage
    
    * Gas improvment on disabled mode check during execution
    
    Between 1 to 22% gas saved during userOp execution
    
    * Missing funds check gas improvments
    
    * Adding a bit of comments
    KONFeature authored and leekt committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    32bbccb View commit details
    Browse the repository at this point in the history
  7. Add p256 validator (#48)

    * Dev (#47)
    
    * Added new ERC1271 signature verification logic in Kernel v0.2.3 (#43)
    
    * Added 1271 wrapper
    
    * Update kernel version to 0.2.3
    
    * use kernel name and version from constants in tests
    
    * added delegatecall support (#44)
    
    * session key validator fixed for batch scenario
    
    * test: fuzz testing for batched options include array
    
    * fix: warning removed, forge fmt (#46)
    
    ---------
    
    Co-authored-by: David Eiber <davideiber@gmail.com>
    
    * Initial commit
    
    * Update P256Validator.t.sol
    
    * forge install: FreshCryptoLib
    
    * Refactor with helper functions
    
    * Add P256Validator, tests, deps
    
    * Remove py scripts used for initial testing
    
    * Update foundry.toml
    
    * update deps
    
    * add non-malleable signatures
    
    ---------
    
    Co-authored-by: taek <leekt216@gmail.com>
    de33 and leekt committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    1a277d8 View commit details
    Browse the repository at this point in the history
  8. deterministic deploy (#51)

    leekt committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    51d7b54 View commit details
    Browse the repository at this point in the history
  9. ⚡️ Optimise gas usage when enabling p256 validator, add a few comments (

    #52)
    
    * ⚡️ Optimise gas usage when enabling p256 validator, add a few comments
    
    - Reducing the number of indexed variable inside a log highly decrease his gas usage, in the p256 validator, we only matter about the kernel account as index (it's 375 gas per topic, so per indexed props, so reducing the index on both key reduce the enabling gas cost by 375 * 4 -> 1500 gas)
     - Add a few reflexion todo comment, do you rly need to send the previous key in the event? Since it's cost with a `sload`& also in the event itself
    
    * ⚡️ Remove the oldKeys for the event signature
    
    * ⚡️ Only compare to raw msg signing instead of eth signed message for p256
    KONFeature authored and leekt committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    f29bc0b View commit details
    Browse the repository at this point in the history
  10. Fix/audit recovery (#53)

    * added threshold check to make sure threshold is not zero
    
    * added userOp.sender on callDataAndNonceHash
    
    * added userOp.sender on callDataAndNonceHash
    
    * added check if guardian is msg.sender
    
    * fmt
    
    * ZeroDev-RW-2 : using live weights
    
    * ZeroDev-RW-4 and ZeroDev-RW-2 fix
    
    * fmt
    leekt committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    0d8214d View commit details
    Browse the repository at this point in the history
  11. rebase master

    leekt committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    466a346 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    ca93bbf View commit details
    Browse the repository at this point in the history