-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/conflict master #57
Merged
Merged
Commits on Nov 15, 2023
-
* Added new ERC1271 signature verification logic in Kernel v0.2.3 (#43) * Added 1271 wrapper * Update kernel version to 0.2.3 * use kernel name and version from constants in tests * added delegatecall support (#44) * session key validator fixed for batch scenario * test: fuzz testing for batched options include array * fix: warning removed, forge fmt (#46) --------- Co-authored-by: David Eiber <davideiber@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 90fa72e - Browse repository at this point
Copy the full SHA 90fa72eView commit details
Commits on Dec 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 160957f - Browse repository at this point
Copy the full SHA 160957fView commit details
Commits on Dec 13, 2023
-
Added new ERC1271 signature verification logic in Kernel v0.2.3 (#43)
* Added 1271 wrapper * Update kernel version to 0.2.3 * use kernel name and version from constants in tests
Configuration menu - View commit details
-
Copy full SHA for bb1f4dc - Browse repository at this point
Copy the full SHA bb1f4dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 218b5e8 - Browse repository at this point
Copy the full SHA 218b5e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 24d9d2f - Browse repository at this point
Copy the full SHA 24d9d2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f0d9bb1 - Browse repository at this point
Copy the full SHA f0d9bb1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 986c502 - Browse repository at this point
Copy the full SHA 986c502View commit details -
Documentation & minor gas optimisation during userOpExecution (#50)
* Add storage slot documentation & run coverage * Gas improvment on disabled mode check during execution Between 1 to 22% gas saved during userOp execution * Missing funds check gas improvments * Adding a bit of comments
Configuration menu - View commit details
-
Copy full SHA for 32bbccb - Browse repository at this point
Copy the full SHA 32bbccbView commit details -
* Dev (#47) * Added new ERC1271 signature verification logic in Kernel v0.2.3 (#43) * Added 1271 wrapper * Update kernel version to 0.2.3 * use kernel name and version from constants in tests * added delegatecall support (#44) * session key validator fixed for batch scenario * test: fuzz testing for batched options include array * fix: warning removed, forge fmt (#46) --------- Co-authored-by: David Eiber <davideiber@gmail.com> * Initial commit * Update P256Validator.t.sol * forge install: FreshCryptoLib * Refactor with helper functions * Add P256Validator, tests, deps * Remove py scripts used for initial testing * Update foundry.toml * update deps * add non-malleable signatures --------- Co-authored-by: taek <leekt216@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1a277d8 - Browse repository at this point
Copy the full SHA 1a277d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 51d7b54 - Browse repository at this point
Copy the full SHA 51d7b54View commit details -
⚡️ Optimise gas usage when enabling p256 validator, add a few comments (
#52) * ⚡️ Optimise gas usage when enabling p256 validator, add a few comments - Reducing the number of indexed variable inside a log highly decrease his gas usage, in the p256 validator, we only matter about the kernel account as index (it's 375 gas per topic, so per indexed props, so reducing the index on both key reduce the enabling gas cost by 375 * 4 -> 1500 gas) - Add a few reflexion todo comment, do you rly need to send the previous key in the event? Since it's cost with a `sload`& also in the event itself * ⚡️ Remove the oldKeys for the event signature * ⚡️ Only compare to raw msg signing instead of eth signed message for p256
Configuration menu - View commit details
-
Copy full SHA for f29bc0b - Browse repository at this point
Copy the full SHA f29bc0bView commit details -
* added threshold check to make sure threshold is not zero * added userOp.sender on callDataAndNonceHash * added userOp.sender on callDataAndNonceHash * added check if guardian is msg.sender * fmt * ZeroDev-RW-2 : using live weights * ZeroDev-RW-4 and ZeroDev-RW-2 fix * fmt
Configuration menu - View commit details
-
Copy full SHA for 0d8214d - Browse repository at this point
Copy the full SHA 0d8214dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 466a346 - Browse repository at this point
Copy the full SHA 466a346View commit details -
Configuration menu - View commit details
-
Copy full SHA for ca93bbf - Browse repository at this point
Copy the full SHA ca93bbfView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.