Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: exporting types from connect.d.ts & ticket.d.ts as these are some types we require during development. #103

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Xenofic
Copy link

@Xenofic Xenofic commented Sep 1, 2024

Changes

  1. The changes this pr introduces is related to the typings for kite.
  2. Exports have been added for types that were not accessible through the default export.
  3. The main index export hasn't been altered as it can cause problems to people who are late adapters to change so instead it can be accessed through the file routing.

Benefits

  1. Now users can type their code more accurately instead of replicating types from docs.
  2. It is much more efficient when it comes to developer experience and is reusable

Problem it solves:

  • Earlier i was having problems with importing types from kite as it didn't export any specific type except for the default types KiteConnect and KiteTicker. Hence these exports will be helpful during development, a image is attached to showcase one of the problems during development.
Screenshot 2024-09-02 at 12 42 26 AM

…e some types we require during development.
@Xenofic
Copy link
Author

Xenofic commented Sep 1, 2024

@ranjanrak Please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant