Skip to content

Commit

Permalink
fix: bring back node 10 build supports
Browse files Browse the repository at this point in the history
  • Loading branch information
aminya committed Oct 23, 2024
1 parent 3d069c4 commit eb0e617
Show file tree
Hide file tree
Showing 4 changed files with 95 additions and 186 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -125,11 +125,11 @@ jobs:
if: ${{ !matrix.docker }}
run: pnpm run build.js

- name: Install Node 12
- name: Install Node 10
if: ${{ !matrix.docker && matrix.os != 'macos-14' }}
uses: actions/setup-node@v4
with:
node-version: 12
node-version: 10
architecture: ${{ env.setup_node_arch }}

- name: Build Native
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,9 @@ during build, you can build this package from source.
Make sure you have the following installed before attempting to build from
source:

- Node.js 12+ or Electron
- Node.js 10+ or Electron
- A working C++17 compiler toolchain with make
- Python 3 with Node 12+ (or legacy Python 2.7)
- Python 3 with Node 10+ (or legacy Python 2.7)
- CMake 2.8+
- curl

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
},
"homepage": "http://zeromq.github.io/zeromq.js/",
"dependencies": {
"@aminya/cmake-ts": "^0.3.0-aminya.5",
"@aminya/cmake-ts": "^0.3.0-aminya.7",
"node-addon-api": "^8.2.1"
},
"devDependencies": {
Expand Down
Loading

0 comments on commit eb0e617

Please sign in to comment.