-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Electron v21 and up. #532
Conversation
@@ -51,7 +52,6 @@ | |||
], | |||
|
|||
'defines': [ | |||
'NAPI_VERSION=3', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't removing this cause issues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, as now <node_version.h> is included, which defines NAPI_VERSION...
If I didn't remove this, I got a compilation error that NAPI_VERSION was being redefined.
I think we should add some Electron tests as well. This way we cannot catch such errors. |
Agreed, as it is a runtime crash, it is very hard to catch. |
Hey guys, @aminya I took the time to check @sophacola 's profile. I think it's a bot. |
@sophacola : does it cause issues then? Strange Issue you created without any info in it... |
@sophacola oops! my apologies: being a 3-day account with 60 reviews triggered my alarms. |
@Bartel-C8 do you know @sophacola ? |
Just blocked and reported them for spam |
Fixes #514
NAPI_VERSION is defined in <node_version.h>