streamlined projection options #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still things to do, but for now this catches many things. One thing is that 'basis' projections are now called hadamard (the proper name of the operation). While 'basis' is still allowed it seems better to streamline a against a common name. Signed-off-by: Nick Papior <nickpapior@gmail.com>
Signed-off-by: Nick Papior <nickpapior@gmail.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Nick Papior <nickpapior@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #875 +/- ##
==========================================
- Coverage 87.00% 86.98% -0.03%
==========================================
Files 403 404 +1
Lines 52589 52638 +49
==========================================
+ Hits 45754 45785 +31
- Misses 6835 6853 +18 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Signed-off-by: Nick Papior <nickpapior@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still things to do, but for now this catches
many things.
One thing is that 'basis' projections are now called hadamard (the proper name of the operation). While 'basis' is still allowed it seems better to streamline a against a common name.
docs/CHANGELOG.md