Code

Refactor write.rs#119

Code

Open

ISSOtm wants to merge 38 commits intozesterer:mainzesterer/ariadne:mainfrom ISSOtm:write_refactorISSOtm/ariadne:write_refactorCopy head branch name to clipboard

+875-911

Commits

Commits on Dec 10, 2024

• Ignore temp files generated by cargo insta

  ISSOtm

  committed
  f73e10a

• Factor out a nb_digits function

  Show description for ba7b721
  ISSOtm

  committed
  ba7b721

• Dedicate a struct name to repeating chars

  Show description for 59790f3
  ISSOtm

  committed
  59790f3

• Make obtaining its colour a method of ReportKind

  Show description for da3e437
  ISSOtm

  committed
  da3e437

• Factor out a fecth_source function

  Show description for e215cc6
  ISSOtm

  committed
  e215cc6

• Use bool::then_some to simplify a few exprs

  ISSOtm

  committed
  8ba9c61

• Remove dead impl Display for Show

  ISSOtm

  committed
  9ea9f77

• Mark Show and Rept as crate-local

  Show description for 07ceb6b
  ISSOtm

  committed
  07ceb6b

• Simplify computation of line numbers a bit

  Show description for 465e3d6
  ISSOtm

  committed
  465e3d6

• Use fetch_source in Report::get_source_groups as well

  Show description for 4d33284
  ISSOtm

  committed
  4d33284

• Factor out a max_line_no function

  Show description for 7c37877
  ISSOtm

  committed
  7c37877

• Force Show to only contain an Option

  Show description for 9b3a043
  ISSOtm

  committed
  9b3a043

• Use more compact print!/write! syntax

  Show description for d199caa
  ISSOtm

  committed
  d199caa

• Use the format! padding feature to pad out line numbers

  Show description for c98d4f6
  ISSOtm

  committed
  c98d4f6

• Factor out a function to obtain the appropriate vbar

  ISSOtm

  committed
  67215dc

• Use a slightly more descriptive name for is_line

  ISSOtm

  committed
  a2f5b69

• [BREAKING] Factor out a Location struct to group that info

  Show description for 638c80c
  ISSOtm

  committed
  638c80c

• Factor out a separate function for group_connector

  Show description for 992c9f3
  ISSOtm

  committed
  992c9f3

• Factor out a is_referencing method

  Show description for a50004c
  ISSOtm

  committed
  a50004c

• Condense the arrow-character-selection logic

  Show description for 12067f0
  ISSOtm

  committed
  12067f0

• Condense the arrow-char-selection margin logic a bit more

  Show description for e8d3706
  ISSOtm

  committed
  e8d3706

• Tweak collection of multi-line labels

  Show description for caada34
  ISSOtm

  committed
  caada34

• Elide one alloc per report emitted

  Show description for f4f5fa2
  ISSOtm

  committed
  f4f5fa2

• Factor out a function for writing margin characters

  ISSOtm

  committed
  6ca20a6

• Switch snapshot tests to Unicode

  Show description for db16ba4
  ISSOtm

  committed
  db16ba4

• Add a few more tests

  ISSOtm

  committed
  bf18d02

• Build the line_labels array in a single statement

  ISSOtm

  committed
  1f8e9a3

• Factor out a function for checking if a label is the margin one

  ISSOtm

  committed
  531a5e0

• Avoid trying to render labels when printing help or notes

  Show description for 138006f
  ISSOtm

  committed
  138006f

• Split off write_margin into two functions

  Show description for 53c0c8a
  ISSOtm

  committed
  53c0c8a

• Remove an unused enumerate()

  ISSOtm

  committed
  a14e462

Commits on Dec 11, 2024

• Add multi-source tests

  ISSOtm

  committed
  059429f

• Factor out a function to write spacer lines

  ISSOtm

  committed
  493d7b5

• Print spacers before groups, rather than after

  Show description for fa4b46a
  ISSOtm

  committed
  fa4b46a

• Iterate on groups by ref instead of by value

  Show description for 2ea74f4
  ISSOtm

  committed
  2ea74f4

• Rearrange a bool expr like Clippy suggests

  ISSOtm

  committed
  825d66e

• Add a test for help and note but no labels

  ISSOtm

  committed
  05524fd

• Do not apply the report kind's colour to its colon

  Show description for 34fe426
  ISSOtm

  committed
  34fe426