Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle withdraw #44

Merged
merged 1 commit into from
Oct 3, 2024
Merged

handle withdraw #44

merged 1 commit into from
Oct 3, 2024

Conversation

fadeev
Copy link
Member

@fadeev fadeev commented Oct 2, 2024 •
edited
Loading

  • If the message is not empty (meainng it was a withdraw and call),
    • if native gas, we call gatewayEVM.execute
    • if ERC-20 or ZETA, we call gatewayEVM.executeWithERC20
  • If the message is empty (meaning it was a withdraw)
    • if it's native gas, then we transfer from TSS to receiver
    • if it's ERC-20 or ZETA, we transfer from ERC-20 custody contract to receiver

@fadeev
Copy link
Member Author

fadeev commented Oct 2, 2024 •
edited
Loading

@skosito can you, please, take a look to see if the updated logic matches to what ZetaChain actually does?

@fadeev fadeev merged commit 1ac7d74 into main Oct 3, 2024
4 checks passed
@fadeev fadeev mentioned this pull request Oct 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbac fbac fbac approved these changes

@lumtis lumtis Awaiting requested review from lumtis lumtis is a code owner

@skosito skosito Awaiting requested review from skosito skosito is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fadeev @fbac