Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle withdrawAndCall with ERC-20s and emit events on revert #45

Merged
merged 5 commits into from
Oct 8, 2024
Merged

Handle withdrawAndCall with ERC-20s and emit events on revert #45

merged 5 commits into from
Oct 8, 2024

Conversation

fadeev
Copy link
Member

@fadeev fadeev commented Oct 4, 2024 •
edited
Loading

  • Emit events when a transaction reverts
  • withdrawAndCall ERC-20s

This was referenced Oct 4, 2024
Merged
Closed
@fadeev fadeev marked this pull request as ready for review October 7, 2024 11:52
@fadeev fadeev marked this pull request as draft October 7, 2024 15:16
@fadeev fadeev changed the title emit events on revert Handle withdrawAndCall with ERC-20s and emit events on revert Oct 8, 2024
@fadeev fadeev marked this pull request as ready for review October 8, 2024 08:44
@fadeev
Copy link
Member Author

fadeev commented Oct 8, 2024

@skosito @fbac please, review.

lumtis
lumtis approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@fadeev fadeev merged commit d7f050f into main Oct 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumtis lumtis lumtis approved these changes

@skosito skosito Awaiting requested review from skosito skosito is a code owner

@fbac fbac Awaiting requested review from fbac fbac is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fadeev @lumtis