feat(zetaclient): enable pprof http server

[gartnera]

Enable the https://pkg.go.dev/net/http/pprof on zetaclient for runtime profiling. zetacored/cometbft is already listing in localhost:6060.

Summary by CodeRabbit

• New Features
  • Introduced profiling capabilities for performance monitoring via an HTTP server.
  • Added a new endpoint for enhanced observability of the application during runtime.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

📝 Walkthrough

📝 Walkthrough

Walkthrough

The changes introduced in the cmd/zetaclientd/start.go file involve the integration of profiling capabilities through the addition of the net/http and net/http/pprof packages. A new goroutine is implemented to run an HTTP server for pprof on port 6061, enhancing the application's observability during runtime. The core logic for initializing the telemetry server and signal handling remains unchanged, ensuring consistent error handling throughout the application.

Changes

File Path	Change Summary
cmd/zetaclientd/start.go	Added net/http and net/http/pprof packages; implemented a goroutine to start an HTTP server for pprof on port 6061; existing telemetry server initialization and signal handling logic remain unchanged.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant PprofServer as Pprof Server
    participant TelemetryServer as Telemetry Server

    Client->>PprofServer: Start on port 6061
    PprofServer-->>Client: Ready for profiling
    Client->>TelemetryServer: Initialize telemetry
    TelemetryServer-->>Client: Telemetry initialized
    Client->>PprofServer: Monitor performance

Loading

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[swift1337]

Consider using bg.Work and bg.WithLogger(), and startLogger

[gartnera]

I'm not sure that want to change the style of this whole file in this PR.

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 6e03cc6 and 256dc61.

📒 Files selected for processing (1)

• cmd/zetaclientd/start.go (2 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

cmd/zetaclientd/start.go (1)

Pattern **/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.

🪛 GitHub Check: lint

cmd/zetaclientd/start.go

[failure] 27-27:
G108: Profiling endpoint is automatically exposed on /debug/pprof (gosec)

---

[failure] 262-262:
G114: Use of net/http serve function that has no support for setting timeouts (gosec)

[github-actions]

!!!WARNING!!!
nosec detected in the following files: cmd/zetaclientd/start.go

Be very careful about using #nosec in code. It can be a quick way to suppress security warnings and move forward with development, it should be employed with caution. Suppressing warnings with #nosec can hide potentially serious vulnerabilities. Only use #nosec when you're absolutely certain that the security issue is either a false positive or has been mitigated in another way.

Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203
Broad #nosec annotations should be avoided, as they can hide other vulnerabilities. The CI will block you from merging this PR until you remove #nosec annotations that do not target specific rules.

Pay extra attention to the way #nosec is being used in the files listed above.