Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address warnings in build #399

Merged
merged 18 commits into from
Oct 17, 2024
3 changes: 3 additions & 0 deletions .github/workflows/generated-files_v2.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ jobs:
tar -zxvf geth-alltools-linux-amd64-1.11.5-a38f4108.tar.gz
sudo mv geth-alltools-linux-amd64-1.11.5-a38f4108/abigen /usr/local/bin/

- name: Run forge --version
run: forge --version

- name: Generate Go packages and types
run: |
yarn generate
Expand Down
15 changes: 9 additions & 6 deletions v2/contracts/evm/ZetaConnectorNative.sol
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,13 @@ contract ZetaConnectorNative is ZetaConnectorBase {
/// @notice Withdraw tokens to a specified address.
/// @param to The address to withdraw tokens to.
/// @param amount The amount of tokens to withdraw.
/// @param internalSendHash A hash used for internal tracking of the transaction.
//// @param internalSendHash A hash used for internal tracking of the transaction (not used currently
// https://github.com/zeta-chain/protocol-contracts/issues/398)
/// @dev This function can only be called by the TSS address.
function withdraw(
address to,
uint256 amount,
bytes32 internalSendHash
bytes32 /*internalSendHash*/
)
external
override
Expand All @@ -48,13 +49,14 @@ contract ZetaConnectorNative is ZetaConnectorBase {
/// @param to The address to withdraw tokens to.
/// @param amount The amount of tokens to withdraw.
/// @param data The calldata to pass to the contract call.
/// @param internalSendHash A hash used for internal tracking of the transaction.
//// @param internalSendHash A hash used for internal tracking of the transaction (not used currently
// https://github.com/zeta-chain/protocol-contracts/issues/398)
/// @dev This function can only be called by the TSS address.
function withdrawAndCall(
address to,
uint256 amount,
bytes calldata data,
bytes32 internalSendHash
bytes32 /*internalSendHash*/
)
external
override
Expand All @@ -75,14 +77,15 @@ contract ZetaConnectorNative is ZetaConnectorBase {
/// @param to The address to withdraw tokens to.
/// @param amount The amount of tokens to withdraw.
/// @param data The calldata to pass to the contract call.
/// @param internalSendHash A hash used for internal tracking of the transaction.
//// @param internalSendHash A hash used for internal tracking of the transaction (not used currently
// https://github.com/zeta-chain/protocol-contracts/issues/398)
/// @dev This function can only be called by the TSS address.
/// @param revertContext Revert context to pass to onRevert.
function withdrawAndRevert(
address to,
uint256 amount,
bytes calldata data,
bytes32 internalSendHash,
bytes32, /*internalSendHash*/
RevertContext calldata revertContext
)
external
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,9 @@ function withdrawAndRevert(

Deposits asset to custody and pay fee in zeta erc20.

**Note:**
This method is deprecated.


```solidity
function deposit(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,9 @@ uint256 public constant MAX_PAYLOAD_SIZE = 1024;
## Functions
### constructor

**Note:**
constructor


```solidity
constructor();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ Withdraw tokens to a specified address.
function withdraw(
address to,
uint256 amount,
bytes32 internalSendHash
bytes32
)
external
override
Expand All @@ -50,7 +50,7 @@ function withdraw(
|----|----|-----------|
|`to`|`address`|The address to withdraw tokens to.|
|`amount`|`uint256`|The amount of tokens to withdraw.|
|`internalSendHash`|`bytes32`|A hash used for internal tracking of the transaction.|
|`<none>`|`bytes32`||


### withdrawAndCall
Expand All @@ -65,7 +65,7 @@ function withdrawAndCall(
address to,
uint256 amount,
bytes calldata data,
bytes32 internalSendHash
bytes32
)
external
override
Expand All @@ -80,7 +80,7 @@ function withdrawAndCall(
|`to`|`address`|The address to withdraw tokens to.|
|`amount`|`uint256`|The amount of tokens to withdraw.|
|`data`|`bytes`|The calldata to pass to the contract call.|
|`internalSendHash`|`bytes32`|A hash used for internal tracking of the transaction.|
|`<none>`|`bytes32`||


### withdrawAndRevert
Expand All @@ -95,7 +95,7 @@ function withdrawAndRevert(
address to,
uint256 amount,
bytes calldata data,
bytes32 internalSendHash,
bytes32,
RevertContext calldata revertContext
)
external
Expand All @@ -111,7 +111,7 @@ function withdrawAndRevert(
|`to`|`address`|The address to withdraw tokens to.|
|`amount`|`uint256`|The amount of tokens to withdraw.|
|`data`|`bytes`|The calldata to pass to the contract call.|
|`internalSendHash`|`bytes32`|A hash used for internal tracking of the transaction.|
|`<none>`|`bytes32`||
|`revertContext`|`RevertContext`|Revert context to pass to onRevert.|


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@ modifier onlyProtocol();

### constructor

**Note:**
constructor


```solidity
constructor();
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
# zContract
[Git Source](https://github.com/zeta-chain/protocol-contracts/blob/main/v2/contracts/zevm/interfaces/UniversalContract.sol)

**Note:**
should be removed once v2 SystemContract is not used anymore.
UniversalContract should be used


## Functions
### onCrossChainCall
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
# zContext
[Git Source](https://github.com/zeta-chain/protocol-contracts/blob/main/v2/contracts/zevm/interfaces/UniversalContract.sol)

**Note:**
should be removed once v2 SystemContract is not used anymore.
MessageContext should be used


```solidity
struct zContext {
Expand Down
2 changes: 1 addition & 1 deletion v2/pkg/address.sol/address.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion v2/pkg/beaconproxy.sol/beaconproxy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion v2/pkg/console.sol/console.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion v2/pkg/core.sol/core.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion v2/pkg/defender.sol/defender.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion v2/pkg/defenderdeploy.sol/defenderdeploy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading