chore: script to deploy GatewayZEVM #408
Conversation
skosito
requested review from
andresaiello,
brewmaster012,
lumtis,
CharlieMc0,
fadeev and
fbac
as code owners
📝 Walkthrough📝 Walkthrough📝 WalkthroughWalkthroughThe changes introduce a new Solidity smart contract file, Changes
Sequence Diagram(s)sequenceDiagram
participant Env as Environment Variables
participant Deploy as DeployGatewayZEVM
participant Impl as GatewayZEVM Implementation
participant Proxy as ERC1967Proxy
Env->>Deploy: Retrieve admin and token addresses
Deploy->>Deploy: Compute expected addresses
Deploy->>Impl: Deploy GatewayZEVM
Impl-->>Deploy: Return implementation address
Deploy->>Proxy: Deploy ERC1967Proxy
Proxy-->>Deploy: Return proxy address
Deploy->>Impl: Initialize with Zeta token and admin
Deploy->>Deploy: Verify token and address
Deploy->>Deploy: Stop transaction broadcast
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #408 +/- ##
=======================================
Coverage 84.27% 84.27%
=======================================
Files 8 8
Lines 388 388
Branches 123 123
=======================================
Hits 327 327
Misses 61 61 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Outside diff range and nitpick comments (1)
v2/scripts/deploy/deterministic/DeployGatewayZEVM.s.sol (1)
50-50: Ensure proper casting of proxy to implementation contractWhen casting the
gatewayProxytoGatewayZEVM, ensure that the proxy correctly forwards calls to the implementation contract. This casting relies on the assumption that the proxy is set up properly.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
v2/.env.sample (1)
13-14: LGTM! Consider adding explanatory comments.The new environment variables
GATEWAY_ADMIN_ADDRESS_ZEVMandWZETAare correctly placed under the "zevm" section and follow the existing naming conventions. This change is consistent with the introduction of the newDeployGatewayZEVMcontract.Consider adding brief comments to explain the purpose of these new variables, similar to the existing comments in the file. For example:
# zevm GATEWAY_PROXY_ZEVM= SYSTEM_CONTRACT= -GATEWAY_ADMIN_ADDRESS_ZEVM= -WZETA= +# Address of the gateway admin for ZEVM +GATEWAY_ADMIN_ADDRESS_ZEVM= +# Address of the wrapped ZETA token on ZEVM +WZETA=
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (2)
- v2/.env.sample (1 hunks)
- v2/scripts/deploy/deterministic/DeployGatewayZEVM.s.sol (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- v2/scripts/deploy/deterministic/DeployGatewayZEVM.s.sol
🧰 Additional context used
Summary by CodeRabbit
New Features
Bug Fixes