Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: templates #18

Merged
merged 3 commits into from
Jul 19, 2023
Merged

fix: templates #18

merged 3 commits into from
Jul 19, 2023

Conversation

fadeev
Copy link
Member

@fadeev fadeev commented Jul 18, 2023 •
edited
Loading

  • refactor the omnichain template gen
  • improved the omnichain template to work with Athens 3 libs

@fadeev fadeev marked this pull request as ready for review July 19, 2023 17:49
@fadeev fadeev requested a review from bbbeeeee July 19, 2023 17:49
@fadeev fadeev linked an issue Jul 19, 2023 that may be closed by this pull request
npx hardhat omni foo fails with no fields #9
Closed
lucas-janon
lucas-janon approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@lucas-janon lucas-janon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fadeev fadeev merged commit 485471a into main Jul 19, 2023
@fadeev fadeev deleted the fix/templating branch August 23, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-janon lucas-janon lucas-janon approved these changes

@andresaiello andresaiello Awaiting requested review from andresaiello andresaiello is a code owner

@bbbeeeee bbbeeeee Awaiting requested review from bbbeeeee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

npx hardhat omni foo fails with no fields
2 participants
@fadeev @lucas-janon