Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, image resize depends on the result of sample size. There's a lot of gap between each sample size value.
For example, resize 3,719 x 2,787 px of original image resolution.
You will see a lot of gap for 1,400 x 1,400 px of target resolution because the result of sample size calculation is 1. So it wasn't resized.
For more precise image resize, we have combine the calculation between,
inSampleSize
,inDensity
andinTargetDensity
together, not onlyinSampleSize
.These are results from new calculation
But there is trade-off between current resize calculation compare to my pull request. It is about the execution time.
If you focus on execution time more than precise resolution, feel free to ignore this pull request or tell me to create it as new constraint.