Issue 1524/text with bullets

[rebecarubio]

Description

This PR updates the dependencies slate and slate-react that handles the text editor. It also fixes a text editor bugs reg regarding an error and the possibility to remove bullet item when it's on the root of the text editor.

Screenshots

Video.sin.titulo.Hecho.con.Clipchamp.8.mp4

Video.sin.titulo.Hecho.con.Clipchamp.10.mp4

Changes

• Upgrades slate dependency to version 0.94.1
• Upgrades slate-react dependency to version 0.98.3
• Removes an empty space string to fix the type error bug.
• Adds a fix in editor function called removeBackwards to allow the user to remove a missing bullet point in the root of editor.
• Trims the instructions string to avoid unnecessary whitespaces.
• Adds a check in ZUITextEditor useEffect to avoid unnecessary re-renders.

Notes to reviewer

None

Related issues

Resolves #1524

[kaulfield23]

I just tested it, and it works well! error 1 is fixed but error 2 is still there, the error 2 is about a bullet that never disappears when you revert the text.
Try this

1. write a word with a bullet and save it. For example,

• hello

2. try to give a change to that word, then you will see revert message next to the button, don't save it, but revert it.
3. You will see the text you wrote with a bullet in number 1.
4. try to remove a bullet by using slate and save it. For example,

hello

6. refresh the page
7. you will see that bullet is still there and impossible to remove it now

If you are unsure about error 2, let me know! I can show you also!

[rebecarubio]

@kaulfield23 I couldn't fix the bug in Firefox so I will maintain that issue documented here #1540. Me and @richardolsson did some more improvements to the Text Editor performance so the PR is again ready to be reviewed.

[kaulfield23]

Nice!!😄 I really like the improvements! feels so good to be able to remove bullets! But I can't fully understand codes here so I want @richardolsson to double check it!

[richardolsson]

I have a question below. Regardless of the answer, I think this looks fine. @kaulfield23 if you're happy with how it works, I give you green light to merge!

[richardolsson]

This seems unnecessarily complex to me. I realize you probably found this solution in the Slate issue tracker, but I'm curious if you know the reason for using hasOwnProperty.call(node[0]… instead of node[0]?.hasOwnProperty(…, etc?

[rebecarubio]

Yes, the reason I was implemented so complex it's because Ancestor and the following types are a mixed of types. The reason to use hasOwnProperty.call it's to avoid a lint error. If I use node[0]?.hasOwnProperty(…, I get the error Do not access Object.prototype method 'hasOwnProperty' from target object.