Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement localization in call assignments insights page header #1550

Merged
merged 5 commits into from
Sep 21, 2023
Merged

Implement localization in call assignments insights page header #1550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d228083
implement localization in call assignments insights page header
rebecarubio Sep 20, 2023
7862924
update yaml file
rebecarubio Sep 20, 2023
870b85b
localize Delete hardcoded string in ViewBrowser
rebecarubio Sep 21, 2023
ed61b59
update yaml file
rebecarubio Sep 21, 2023
3dfd9fe
move to callAssignments insightHeader localized string and update yam…
rebecarubio Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/features/callAssignments/l10n/messageIds.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ export default makeMessages('feat.callAssignments', {
subtitle: m('Targets that meet the done criteria'),
title: m('Done'),
},
insightsHeader: m('Calls and conversations'),
organizerActionPane: {
markAsSolved: m('Mark as solved'),
markAsUnsolved: m('Mark as unsolved'),
Expand Down
2 changes: 1 addition & 1 deletion src/features/views/components/ViewBrowser/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ const ViewBrowser: FC<ViewBrowserProps> = ({
},
{
id: 'delete-item',
label: 'Delete',
label: messages.browser.menu.delete(),
onSelect: (e) => {
e.stopPropagation();
showConfirmDialog({
Expand Down
1 change: 1 addition & 0 deletions src/features/views/l10n/messageIds.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ export default makeMessages('feat.views', {
},
},
menu: {
delete: m('Delete'),
rename: m('Rename'),
},
moveToFolder: m<{ folder: ReactElement }>('Move to {folder}'),
Expand Down
2 changes: 2 additions & 0 deletions src/locale/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ feat:
defineButton: Edit done criteria
subtitle: Targets that meet the done criteria
title: Done
insightsHeader: Calls and conversations
organizerActionPane:
markAsSolved: Mark as solved
markAsUnsolved: Mark as unsolved
Expand Down Expand Up @@ -1346,6 +1347,7 @@ feat:
warning: Deleting this view is a permanent action which can't be undone. Are you
sure you want to continue?
menu:
delete: Delete
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here as well. but I'm not sure. What do you think?

rename: Rename
moveToFolder: Move to {folder}
moveToRoot: Move to all views
Expand Down
6 changes: 5 additions & 1 deletion src/pages/organize/[orgId]/projects/[campId]/callassignments/[callAssId]/insights.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ import APIError from 'utils/apiError';
import CallAssignmentLayout from 'features/callAssignments/layout/CallAssignmentLayout';
import CallAssignmentModel from 'features/callAssignments/models/CallAssignmentModel';
import { callAssignmentQuery } from 'features/callAssignments/api/callAssignments';
import messageIds from 'features/callAssignments/l10n/messageIds';
import { Msg } from 'core/i18n';
import { PageWithLayout } from 'utils/types';
import { scaffold } from 'utils/next';
import useModel from 'core/useModel';
Expand Down Expand Up @@ -92,7 +94,9 @@ const AssignmentPage: PageWithLayout<AssignmentPageProps> = ({
<Head>
<title>{model.getData().data?.title}</title>
</Head>
<Typography variant="h3">Calls and conversations</Typography>
<Typography variant="h3">
<Msg id={messageIds.insightsHeader} />
</Typography>
<ZUIQuery queries={{ statsQuery }}>
{({ queries }) => {
const data = queries.statsQuery.data.dates.map((d: DateStats) => {
Expand Down