Rename lists to views #1554
Rename lists to views #1554
Conversation
There was a problem hiding this comment.
The changes to the makeMessages() prefix looks good to me, but I don't understand why we would need to change the test. They should be unrelated, and to me the test looked right before (using "list"). If that test failed, I believe that it's either flaky (retry it) or the code it's testing is wrong (fix it).
| @@ -78,7 +78,7 @@ test.describe('View detail page', () => { | |||
| expect(columnPostLogs).toHaveLength(2); | |||
|
|
|||
| // Expect that correctly localised strings sent when posting | |||
| expect(viewPostLogs[0].data?.title).toEqual('New list'); | |||
| expect(viewPostLogs[0].data?.title).toEqual('New View'); | |||
There was a problem hiding this comment.
This should not have to change. The correct text to use for a newly created list is "New list". Why did this change?
There was a problem hiding this comment.
The test failed there and result said it was expecing to have New list but the result was New View so I fixed it to New View @richardolsson
There was a problem hiding this comment.
Should I fix it as before and retry the test?
Description
This PR fixes a bug where it breaks localization in view
Screenshots
Changes
liststoviewsNotes to reviewer
Related issues
Undocumented