-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
My home #2425
Merged
Merged
My home #2425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, the useUser() hook was defined in useFocusDate.ts and used a context defined there, while a separate UserContext was defined in env/UserContext.ts. This PR moves the useUser() to it's own module and reuses the existing context.
…adListIfNecessary()
richardolsson
commented
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed all the code, mine and @ziggabyte's!
ziggabyte
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we did great. i approve.
This was referenced Dec 17, 2024
Closed
This was referenced Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR creates a prototype replacement for the Gen2 "dashboard".
Screenshots
Changes
useRemoteList()
which uses React Suspense instead of our ownIFuture
interfaceredirectIfLoginNeeded()
that can be used in app router pages to verify authentication before rendering the page (and redirecting to the login page if necessary)useIncrementalDelay()
which can be used when animating things one after the otherZUIModalBackground
component that can be used for the Modal component in the upcoming ZUI design systemZUILogoLoadingIndicator
which is an animated version of the Zetkin logo to use when loadingUserContext
/UserProvider
/useUser()
Notes to reviewer
We're sorry.
Related issues
Resolves #1616