Fix compatibility issue with CMake 3.10 #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
target_link_libraries/INTERFACE doesn't seem to work on CMake 3.10, but directly setting the property does work. Fixes #390.
mathstuf
approved these changes
Dec 18, 2020
|
This indeed solves my issue in #390 |
|
@s-trinh Great, thanks! And sorry about the regressions. I'm going to release v1.11.3 shortly. |
TheVice
added a commit
to TheVice/Ant4C
that referenced
this pull request
Feb 16, 2021
Adding of this function required for checking at script available to use some of function on Windows Server platform, for example 'cygpath::get-dos-path'. Structure OperatingSystem was hidden. Added 'operating_system_init', 'operating_system_is_windows_server' and 'platform_is_windows_server' functions. [tests.xml] added calls of functions from 'operating-system' and 'platform' name spaces. [ant4c.net.framework.module] renamed source files of the module. Added hash sums of the nuget package to the SHA3-224SUMS and MD5SUMS files. [CMakeLists] added workaround approach to use pugixml at some environment ( OpenBSD 6.8 for example ) where find_package may create issue for using direct source of the packages in case package from system repository was not installed ( pkg_add libpugixml ). More details can be found at the issue discussion zeux/pugixml#390 and pull request zeux/pugixml#391
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
target_link_libraries/INTERFACE doesn't seem to work on CMake 3.10, but
directly setting the property does work.
Fixes #390.