Warn if PUGIXML_STRING_VIEW is set without CMAKE_CXX_STANDARD #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even if the compiler supports C++17, we define CMAKE_CXX_STANDARD as 11 by default which implicitly disables string_view support; for now warn in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if the compiler supports C++17, we define CMAKE_CXX_STANDARD as 11 by default which implicitly disables string_view support; for now warn in this case.
Note: I am not sure why we set CMAKE_CXX_STANDARD to 11. This has been added 5 years ago as part of CMake modernization but I don't know what the justification was for this particular change. We could set it to 17 if the option is enabled, but since the intent for the STRING_VIEW option to be there just for transition, after this option is removed and string_view is enabled by default, C++17 will still need to be set by the user.
We could also set CMAKE_CXX_STANDARD to 17 by default (and remove CMAKE_CXX_STANDARD_REQUIRED to avoid compatibility issues); I'm not sure what the implications for a change like this would be but that's probably best done after the next release.
Related: #626